]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
dash: Move item declaration on top
authorAlessandro Bono <alessandro.bono369@gmail.com>
Sun, 15 Jan 2023 13:31:08 +0000 (14:31 +0100)
committerMarge Bot <marge-bot@gnome.org>
Sat, 21 Oct 2023 15:09:35 +0000 (15:09 +0000)
Otherwise it is not clear what is the item variable that we are
passing to _itemMenuStateChanged().

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2988>

js/ui/dash.js

index 0841b6c047c05a2544577d9f16eb00215297b5e2..98ec159cb8f7d79846ede8e824d1629b1487e2af 100644 (file)
@@ -512,13 +512,13 @@ export const Dash = GObject.registerClass({
     }
 
     _createAppItem(app) {
+        let item = new DashItemContainer();
         let appIcon = new DashIcon(app);
 
         appIcon.connect('menu-state-changed', (o, opened) => {
             this._itemMenuStateChanged(item, opened);
         });
 
-        let item = new DashItemContainer();
         item.setChild(appIcon);
 
         // Override default AppIcon label_actor, now the